Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(cli): fix context init in TestSupportBundle#16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 1 commit intomainfrommafredri/test-fix-cli-bundle
Jan 17, 2025

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJan 17, 2025•
edited
Loading

Saw this flake but I didn't discern the exact cause:https://github.com/coder/coder/actions/runs/12828659209/job/35773186400?pr=16170

So I fixed the contexts here just in case.

This was suspicious:

    t.go:106: 2025-01-17 12:06:10.009 [debu]  coderd.coord: peerReadLoop context done  peer_id=80ca93ed-5546-4698-920d-046008c5b74d  peer_name=client  request_id=b6fc52b2-538e-48fa-b50c-8e349eb74d48

And given the even round number of 30s here:

    t.go:106: 2025-01-17 12:06:39.926 [debu]  coderd: GET  host=localhost:51586  path=/api/v2/debug/health  proto=HTTP/1.1  remote_addr=127.0.0.1  start="2025-01-17T12:06:09.925865Z"  took=30.000337625s  status_code=404  latency_ms=30000  request_id=45adda5d-d9d8-4dc0-98b0-317b0ddf625a

@mafredrimafredri merged commit860d17a intomainJan 17, 2025
47 checks passed
@mafredrimafredri deleted the mafredri/test-fix-cli-bundle branchJanuary 17, 2025 12:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mafredri@dannykopping@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp