Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(enterprise/coderd): use filesystem mirror for providers in TestWorkspaceTagsTerraform#16155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/flake/testworkspacetagsterraform
Jan 15, 2025

Conversation

johnstcn
Copy link
Member

Fixescoder/internal#266 (hopefully)

Each instance of this test has to download the coder/coder Terraform provider.
To mitigate this, only download the providers once using afilesystem_mirror (ref:https://developer.hashicorp.com/terraform/cli/config/config-file#provider-installation)

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice 👍

// downloadProviders is a test helper that creates a temporary file and writes a
// terraform CLI config file with a provider_installation stanza for coder/coder
// using dev_overrides. It also fetches the latest provider release from GitHub
// and extracts the binary to the temporary dir. It is the responsibility of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love the line length alignment here 😍, too bad about the third line missing one char 🤣

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did that specifically to annoy you ;-P

@johnstcnjohnstcn changed the titlechore(enterprise/coderd): TestWorkspaceTagsTerraform: use filesystem mirror for providerschore(enterprise/coderd): use filesystem mirror for providers in TestWorkspaceTagsTerraformJan 15, 2025
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@johnstcnjohnstcn merged commit3a81aac intomainJan 15, 2025
35 checks passed
@johnstcnjohnstcn deleted the cj/flake/testworkspacetagsterraform branchJanuary 15, 2025 20:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake: TestWorkspaceTagsTerraform: context canceled
3 participants
@johnstcn@mafredri@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp