- Notifications
You must be signed in to change notification settings - Fork1k
feat: open app in tab or slim-window#16152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
code-asher left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This makes me happy, I like tabs over the slim window
| ); | ||
| return; | ||
| } | ||
| case"tab":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this be thedefault case or are we guaranteedopen_in will always be set and only contain one of these two values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We ensure it will always be set and contain one of these two values.
| if(app.external&&!app.url.startsWith("http")){ | ||
| // If the protocol is external the browser does not | ||
| // redirect the user from the page. | ||
| constisBrowserProtocol=app.external&&!app.url.startsWith("http"); |
code-asherJan 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh wait this is actually the opposite, right?Not a browser protocol (likevscode://). MaybeisExternalProtocol?
Well, I guess the browser does handle it by launching the external app, butisBrowser makes me think ofhttp://
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It made sense to me before you brought this up—now I’m not so sure. MaybeshouldOpenAppExternally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like that name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM - Just agree with@code-asher comment on the naming forisBrowserProtocol which seems to be the opposite but as the logic itself seems good i'll not block here.
eda8190 intomainUh oh!
There was an error while loading.Please reload this page.
Closecoder/terraform-provider-coder#297