NotificationsYou must be signed in to change notification settings
Fork924
Star10.1k

fix(scripts/coder-dev.sh): silence output if stdout is not a TTY#16131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 1 commit intomainfromcj/coder-dev-stdout

Jan 14, 2025

Merged

fix(scripts/coder-dev.sh): silence output if stdout is not a TTY#16131

johnstcn merged 1 commit intomainfromcj/coder-dev-stdout

Jan 14, 2025

Conversation

Copy link

Member

johnstcn commentedJan 14, 2025

Themake -j output was sometimes emitting non-JSON output fromgo generate, resulting in errors like the below:

++ /home/coder/src/coder/coder/scripts/coder-dev.sh organizations show me -o json++ jq -r '.[] | select(.is_default) | .name'parse error: Invalid numeric literal at line 1, column 3

This PR modifiescoder-dev.sh to silence the output ofmake if the output is not a TTY.

fix(scripts/develop.sh): silence output if stdout is not a TTY

7cea0b8

johnstcn requested a review frommafredri

January 14, 2025 13:40

johnstcn self-assigned this

Jan 14, 2025

johnstcn changed the title~~fix(scripts/develop.sh): silence output if stdout is not a TTY~~fix(scripts/coder-dev.sh): silence output if stdout is not a TTY

Jan 14, 2025

johnstcn requested a review fromdannykopping

January 14, 2025 14:31