Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add the --ephemeral server flag#16126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 8 commits intomainfromhugodutka/ephemeral-flag
Jan 20, 2025
Merged

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJan 13, 2025
edited
Loading

Another PR to address#15109.

Changes:

  • Introduces the--ephemeral flag, which changes the Coder config directory to a temporary location. The config directory is where the built-in PostgreSQL stores its data, so using a new one results in a deployment with a fresh state.

The--ephemeral flag is set to replace the--in-memory flag once the in-memory database is removed.

@hugodutkahugodutkaforce-pushed thehugodutka/ephemeral-flag branch frome9ea1ef to54a82eaCompareJanuary 16, 2025 15:33
@hugodutkahugodutka marked this pull request as ready for reviewJanuary 16, 2025 18:40
@hugodutka
Copy link
ContributorAuthor

It looks like the weekly docs check is failing because some external links went offline, not because of any changes I made.

@hugodutkahugodutka marked this pull request as draftJanuary 16, 2025 18:41
@hugodutkahugodutka marked this pull request as ready for reviewJanuary 16, 2025 21:43
@dannykopping
Copy link
Contributor

Why can't we just redefine what--in-memory does?

It's a hidden field already, and I can't think of a use-case for customers, so changing the behaviour here seems fine to me (provided we note this in the release notes).

@hugodutka
Copy link
ContributorAuthor

@dannykopping, many of the CLI tests currently use--in-memory (seehere). We'd need to modify them, as the new approach would spawn a new Postgres process for every test, which is too heavy-weight. I was planning to make--in-memory a deprecated alias for--ephemeral once the in-memory DB is fully removed. This way, we can split the migration into smaller PRs that are easier to review.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@hugodutkahugodutkaforce-pushed thehugodutka/ephemeral-flag branch from075e524 to068b594CompareJanuary 20, 2025 13:09
@hugodutkahugodutka merged commit23cf61a intomainJan 20, 2025
34 of 36 checks passed
@hugodutkahugodutka deleted the hugodutka/ephemeral-flag branchJanuary 20, 2025 13:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp