Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: document local install.sh script#16125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 8 commits intomainfromlilac/docs-local-install-script
Jan 21, 2025

Conversation

aslilac
Copy link
Member

To be merged once#16064 lands

This neat little addition feels worth documenting!

Copy link
Contributor

@EdwardAngertEdwardAngert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm trying to find a way to clarify the way both the script and binaries are available, and I'm not sure I've done that, so I suggested some edits, and fully expect that they should be edited further.

Additionally, should we more-strongly recommend that the script be included in templates?

aslilacand others added3 commitsJanuary 15, 2025 14:11
Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com>
Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com>
Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com>
@aslilac
Copy link
MemberAuthor

Additionally, should we more-strongly recommend that the script be included in templates?

I'm not sure. Probably not immediately. I think it'd be a good idea to dogfood it for a while and then maybe then if it proves to be a good idea we can more strongly recommend it to users.

It's also lacking a good Windows equivalent, and idk how much of an issue that'll be for customers.

EdwardAngert reacted with thumbs up emoji

@matifali
Copy link
Member

matifali commentedJan 16, 2025
edited
Loading

It's also lacking a good Windows equivalent, and idk how much of an issue that'll be for customers.

Many of our users use Windows or macOS devices. So this will be an issue.
We could provide a Windows equivalent install script, too.

iwrhttps://coder.example.com/install.ps1|iex

Also, let's include these as part of CLI suggestions when we detect a version mismatch instead of documenting this in docs. E.g.,

version mismatch: client v2.17.0+5a6d23a, server v2.18.2-devel+3a81aac31- download the server version with: 'curl -L https://coder.com/install.sh | sh -s -- --version 2.18.2-devel'+ Download the server version with: 'curl -L https://dev.coder.com/install.sh | sh'

And best if we can automagically do that,

version mismatch: client v2.17.0+5a6d23a, server v2.18.2-devel+3a81aac31- download the server version with: 'curl -L https://coder.com/install.sh | sh -s -- --version 2.18.2-devel'+ Download the matching version from the server (y/n): y

Note

These are suggestions and not hard requirements, so take them with a grain of salt.

@aslilac
Copy link
MemberAuthor

providing a windows equivalent and changing the cli are waaaay out of scope for this PR. I'm relatively comfortable writing bash scripts, but powershell is a whole different beast.

EdwardAngert reacted with thumbs up emoji

@aslilacaslilac merged commit250f3c7 intomainJan 21, 2025
29 checks passed
@aslilacaslilac deleted the lilac/docs-local-install-script branchJanuary 21, 2025 21:16
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EdwardAngertEdwardAngertEdwardAngert approved these changes

@matifalimatifaliAwaiting requested review from matifali

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@matifali@EdwardAngert

[8]ページ先頭

©2009-2025 Movatter.jp