Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: only notify about CI failure onmain ifrequired job fails#16114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 2 commits intomainfromdk/ci-failure
Jan 13, 2025

Conversation

dannykopping
Copy link
Contributor

This should be the last PR to get this working

Looks like thenightly-gauntlet is working as expected, and this is a clone of that.

@ethanndickson@matifali sorry fellas, last review from me I'm hoping

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykoppingenabled auto-merge (squash)January 13, 2025 12:54
@ethanndickson
Copy link
Member

ethanndickson commentedJan 13, 2025•
edited
Loading

"text": "*Failed Job:*\n${{ github.job }}"

From your earlier screenshot, I believe this will always benotify-slack-on-failure. Idk how easy fixing it is - can probably just remove for now, the notif thatsomething has failed should be good enough!

@dannykopping
Copy link
ContributorAuthor

"text": "*Failed Job:*\n${{ github.job }}"

From your earlier screenshot, I believe this will always benotify-slack-on-failure. Idk how easy fixing it is - can probably just remove for now, the notif thatsomething has failed should be good enough!

Haha Ijust noticed that now too. Looking into it.

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykoppingenabled auto-merge (squash)January 13, 2025 13:58
@dannykoppingdannykopping merged commit22236f2 intomainJan 13, 2025
34 checks passed
@dannykoppingdannykopping deleted the dk/ci-failure branchJanuary 13, 2025 14:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@ethanndicksonethanndicksonAwaiting requested review from ethanndickson

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dannykopping@ethanndickson@matifali
[8]ページ先頭
©2009-2025 Movatter.jp