Jan 13, 2025 · Jan 13, 2025 · Jan 13, 2025 · Jan 13, 2025
diff --git a/.github/workflows/nightly-gauntlet.yaml b/.github/workflows/nightly-gauntlet.yaml
          api-key: ${{ secrets.DATADOG_API_KEY }}

  notify-slack-on-failure:
    needs:
      - go-race
      - go-timing
    runs-on: ubuntu-latest
    if:always() &&failure()
    if: failure()

    steps:
      - name: Send Slack notification
Original file line number	Diff line number	Diff line change
Expand Up		@@ -74,8 +74,11 @@ jobs:
		api-key: ${{ secrets.DATADOG_API_KEY }}

		notify-slack-on-failure:
		needs:
		- go-race
		- go-timing
		runs-on: ubuntu-latest
		if:always() &&failure()
Copy link Member ethanndicksonJan 13, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `always() && failure()` is the same as`failure()`. I think the operative part here is the`needs` section? Copy link ContributorAuthor dannykoppingJan 13, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I mentioned the operative part in the title, although agree this could've been more explicit. Clause Sonnet suggested that`always()` could be used if you wanted to handle all jobs (i.e. not have to exhaustively define`needs`), but maybe that's wrong. I hate GHA.
		if: failure()

		steps:
		- name: Send Slack notification
Expand Down