NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

chore: predicate slack notification job on other jobs#16106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dannykopping merged 1 commit intomainfromdk/nightly2

Jan 13, 2025

Merged

chore: predicate slack notification job on other jobs#16106

dannykopping merged 1 commit intomainfromdk/nightly2

Jan 13, 2025

Conversation

Copy link

Contributor

dannykopping commentedJan 13, 2025

always() does not seem to work

Extending#16105

dannykopping requested review fromethanndickson andmatifali

January 13, 2025 11:25

github-actionsbot assigneddannykopping

Jan 13, 2025

Predicate slack notification job on other jobs

4b95ea4

always() does not seem to workSigned-off-by: Danny Kopping <danny@coder.com>

dannykopping force-pushed thedk/nightly2 branch frombcb70a9 to4b95ea4Compare

January 13, 2025 11:26

ethanndickson approved these changes

Jan 13, 2025

View reviewed changes

.github/workflows/nightly-gauntlet.yaml

		-go-race
		-go-timing
		runs-on:ubuntu-latest
		if:always() &&failure()

Copy link

Member

ethanndicksonJan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

always() && failure() is the same asfailure(). I think the operative part here is theneeds section?

Copy link

ContributorAuthor

dannykoppingJan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I mentioned the operative part in the title, although agree this could've been more explicit.

Clause Sonnet suggested thatalways() could be used if you wanted to handle all jobs (i.e. not have to exhaustively defineneeds), but maybe that's wrong.

I hate GHA.

Copy link

Member

ethanndickson commentedJan 13, 2025

Also, are you able to test it by manually specifying your branch?

Copy link

ContributorAuthor

dannykopping commentedJan 13, 2025•
edited
Loading

Also, are you able to test it by manually specifying your branch?

I'm busy with other things so didn't bother to check the semantics of thenightly-gauntlet workflow to see if it's work outside ofmain, but good idea I'll try in my branch first.

"We do this not because it's easy, but because wethought it'd be easy"

Copy link

ContributorAuthor