Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: enable editing of IDP sync configuration for groups and roles in the UI#16098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 40 commits intomainfromjaaydenh/idp-group-role-sync-crud
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
40 commits
Select commitHold shift + click to select a range
96b0c09
chore: remove stack component
jaaydenhJan 10, 2025
a88b72f
chore: styling cleanup
jaaydenhJan 10, 2025
cb00c73
feat: add form and mutation queries
jaaydenhJan 10, 2025
4b15a2a
feat: add form fields
jaaydenhJan 12, 2025
0befeca
chore: add delete button
jaaydenhJan 14, 2025
f8349de
fix: update input component to 40px height
jaaydenhJan 14, 2025
7124c11
fix: fix styles for MultiSelectCombobox
jaaydenhJan 14, 2025
30c8a9c
chore: update export policy button design
jaaydenhJan 14, 2025
a7c954b
fix: update copy and spacing
jaaydenhJan 14, 2025
c09a3f3
chore: update styles
jaaydenhJan 14, 2025
8714f5e
fix: fix storybook tests
jaaydenhJan 14, 2025
b558f35
fix: fix legacy group mappings styles
jaaydenhJan 14, 2025
aa0e53c
fix: format
jaaydenhJan 14, 2025
7635856
feat: create link component
jaaydenhJan 14, 2025
91ca380
fix: use new Link component
jaaydenhJan 15, 2025
328ce2f
fix: use correct field value
jaaydenhJan 15, 2025
52d563c
fix: update error handling
jaaydenhJan 15, 2025
b1d7649
feat: add e2e tests for group and role sync
jaaydenhJan 15, 2025
b3812f1
chore: update link components
jaaydenhJan 15, 2025
d19a0dc
fix: remove unnecessary arbitrary values
jaaydenhJan 16, 2025
43159ff
chore: extract Form components
jaaydenhJan 16, 2025
528f2d8
fix: adding loading spinners
jaaydenhJan 16, 2025
d283fa1
fix: update icon button sizing to match design
jaaydenhJan 17, 2025
ad2fc45
chore: improve e2e tests
jaaydenhJan 20, 2025
c99e009
fix: change to min width fit
jaaydenhJan 20, 2025
31cd599
fix: updates for PR review comments
jaaydenhJan 20, 2025
2354883
fix: remove async from onClick
jaaydenhJan 22, 2025
3c63c8c
fix: fix tabs styling
jaaydenhJan 22, 2025
623a50e
fix: format
jaaydenhJan 22, 2025
5779c8d
fix: updates for PR comments
jaaydenhJan 22, 2025
395fdc8
chore: switch to useId for form ids
jaaydenhJan 22, 2025
79ce400
fix: styling
jaaydenhJan 22, 2025
854684a
fix: add resolves
jaaydenhJan 22, 2025
50c12db
fix: revert button styles
jaaydenhJan 22, 2025
16665e2
chore: use Link component
jaaydenhJan 22, 2025
3dbcee3
fix: show form errors and update mapping schema validation
jaaydenhJan 27, 2025
9b709ae
fix: remove unnecessary async
jaaydenhJan 27, 2025
bee5783
fix: remove useEffect
jaaydenhJan 27, 2025
d3b64b2
fix: error display
jaaydenhJan 27, 2025
0362c16
fix: format
jaaydenhJan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix: updates for PR comments
  • Loading branch information
@jaaydenh
jaaydenh committedJan 22, 2025
commit5779c8d1c698343c1706bcdd90611a7a55d04008
5 changes: 4 additions & 1 deletionsite/src/components/Tabs/Tabs.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,10 @@ export const Tabs: FC<TabsProps> = ({ className, active, ...htmlProps }) => {
<div
// Because the Tailwind preflight is not used, its necessary to set border style to solid and
// reset all border widths to 0 https://tailwindcss.com/docs/border-width#using-without-preflight
className={cn("border-0 border-b border-solid border-border", className)}
className={cn(
"border-0 border-b border-solid border-border",
className,
)}
{...htmlProps}
/>
</TabsContext.Provider>
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ import { Link } from "components/Link/Link";
import { Paywall } from "components/Paywall/Paywall";
import { useFeatureVisibility } from "modules/dashboard/useFeatureVisibility";
import { useOrganizationSettings } from "modules/management/OrganizationSettingsLayout";
import{typeFC, useEffect } from "react";
import type{ FC } from "react";
import { Helmet } from "react-helmet-async";
import { useMutation, useQueries, useQueryClient } from "react-query";
import { useParams } from "react-router-dom";
Expand DownExpand Up@@ -59,11 +59,11 @@ export const IdpSyncPage: FC = () => {
);

const error =
patchGroupSyncSettingsMutation.error ||
patchRoleSyncSettingsMutation.error ||
groupIdpSyncSettingsQuery.error ||
roleIdpSyncSettingsQuery.error ||
groupsQuery.error ||
patchGroupSyncSettingsMutation.error ||
patchRoleSyncSettingsMutation.error;
groupsQuery.error;

const groupsMap = new Map<string, string>();
if (groupsQuery.data) {
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,6 +85,6 @@ export const RolesTab: Story = {
const canvas = within(canvasElement);
const rolesTab = await canvas.findByText("Role sync settings");
await user.click(rolesTab);
await expect(canvas.findByText("IdP role")).resolves.toBeVisible();
await expect(canvas.findByText("IdP role")).toBeVisible();
},
};

[8]ページ先頭

©2009-2025 Movatter.jp