Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: ensure active Deployment Page nav links are highlighted#16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 1 commit intomainfrommes/deploy-links-fix
Jan 10, 2025

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedJan 10, 2025•
edited
Loading

Addendum to#16073. We accidentally broke a few things with the change, and this make things right.

Changes made

  • Updated links in the deployment settings page to ensure that they're highlighted properly
  • Updated comment about previous PR to make sure it's clear why we were doing things a certain way.

Screenshots

(Look at the General link)

Before
Screenshot 2025-01-10 at 9 55 22 AM

After
Screenshot 2025-01-10 at 9 55 30 AM

@ParkreinerParkreiner self-assigned thisJan 10, 2025
Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ParkreinerParkreiner changed the titlefix: ensure active deployment nav links are highlightedfix: ensure active Deployment Page nav links are highlightedJan 10, 2025
@Parkreiner
Copy link
MemberAuthor

Parkreiner commentedJan 10, 2025•
edited
Loading

@jaaydenh I'm making this a hotfix, but I'm tagging you so you're aware. We missed that the previous PR broke the Deployment page

The weird thing is that none of the changes here got detected as a diff in Storybook, so I'll try looking into that later today

@ParkreinerParkreiner merged commit8b9763d intomainJan 10, 2025
39 checks passed
@ParkreinerParkreiner deleted the mes/deploy-links-fix branchJanuary 10, 2025 14:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

Assignees

@ParkreinerParkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp