Reduces test parallelism on Windows in CI
Unifies wait intervals on Windows with Linux and macOS. Previously we had custom intervals for Windows to reduce test flakiness on smaller CI workers, but we don't run tests on small CI workers anymore. Due to how our CI file is defined, forks run tests on small CI machines, but I'm not sure if the different intervals actually help or whether that's a heuristic that happened to fix issues on a particular day and was it ever reevaluated. I propose we make the change and if someone complains, revert it.

In particular, reduced test parallelism seems to actually help: I was able to run Windows tests 5 times in a row without flakes. Not sure if that's going to fix the problem long term, but it seems worth trying.

remove custom wait durations for windows tests

ea01035

github-actionsbot assignedhugodutka

Jan 10, 2025

hugodutka added3 commits

January 10, 2025 11:27

remove Windows build constraint from duration.go

d9741b8

reduce test parallelism on windows

3fa3ea6

add a comment

5577757

hugodutka changed the title~~chore: remove custom wait durations for windows tests~~chore: reduce Windows PG tests flakiness

Jan 10, 2025

hugodutka marked this pull request as ready for review

January 10, 2025 13:37

hugodutka requested a review fromdannykopping

January 10, 2025 13:52

hugodutka mentioned this pull request

Jan 10, 2025

flake:TestLogout/NoURLFilecoder/internal#257

Open

mafredri approved these changes

Jan 10, 2025

View reviewed changes

testutil/duration.go

		@@ -1,5 +1,3 @@
		//go:build !windows

Copy link

Member

mafredriJan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change has me worried due to previously not only Windows runners being underpowered but disk I/O was always slower on Windows too. Feel free to have a go at this but I'd advice to be prepared to revert it 😄