Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add --ssh-host-prefix flag for "coder ssh"#16088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bcpeinhardt merged 1 commit intocoder:mainfromaaronlehmann:ssh-host-prefix-flag
Jan 14, 2025

Conversation

aaronlehmann
Copy link
Contributor

@aaronlehmannaaronlehmann commentedJan 9, 2025•
edited
Loading

This adds a flag matching--ssh-host-prefix fromcoder config-ssh tocoder ssh. By trimming a custom prefix from the argument, we can set up wildcard-basedHost entries in SSH config for the IDE plugins (and eventuallycoder config-ssh).

We also replace-- in the argument with/, so ownership can be specified in wildcard-based SSH hosts like<owner>--<workspace>.

Replaces#16087.

Part of#14986.

Related to#16078 and#16080.

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelJan 9, 2025
@aaronlehmannaaronlehmann changed the titlefeat: --ssh-host-prefix flag for "coder ssh"feat: add --ssh-host-prefix flag for "coder ssh"Jan 9, 2025
@aaronlehmann
Copy link
ContributorAuthor

The test failure looks unrelated. Flaky test?

@bcpeinhardt
Copy link
Contributor

Looks like it, although I'm having trouble getting it to Flake to confirm :/
My suspicion is the flake is latency between these two pieces of text being written to stdout:
https://github.com/coder/coder/pull/16088/files#diff-2caee0e73c6bfeed4632d116a45feccdbdb7a4dfd21a7b7aad510cf087873c9eR223

@bcpeinhardt
Copy link
Contributor

Re-running the tests passed, it's a flake ❄️ I'll come back to this in the morning and try to fix it 😎

@bcpeinhardt
Copy link
Contributor

Ah hey the flake was caught and fixed yesterday, just in the process of being merged:coder/internal#269

aaronlehmann added a commit to aaronlehmann/jetbrains-coder that referenced this pull requestJan 10, 2025
This simplifies the written SSH config and avoids the need to make anAPI request for every workspace the filter returns. This can removeminutes from the "Configuring Coder CLI..." step when the user hasaccess to many workspaces (for example, an admin who wants the option ofconnecting to anyone's workspace on a large deployment).Depends oncoder/coder#16088
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

This adds a flag matching `--ssh-host-prefix` from `coder config-ssh` to`coder ssh`. By trimming a custom prefix from the argument, we can setup wildcard-based `Host` entries in SSH config for the IDE plugins (andeventually `coder config-ssh`).We also replace `--` in the argument with `/`, so ownership can bespecified in wildcard-based SSH hosts like `<owner>--<workspace>`.
@bcpeinhardtbcpeinhardt merged commit1aa9e32 intocoder:mainJan 14, 2025
32 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bcpeinhardtbcpeinhardtbcpeinhardt approved these changes

@mafredrimafredrimafredri approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@aaronlehmannaaronlehmann

Labels
communityPull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aaronlehmann@bcpeinhardt@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp