- Notifications
You must be signed in to change notification settings - Fork914
feat: add --network-info-dir and --network-info-interval flags to coder ssh#16078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…er sshThis is the first in a series of PRs to enable "coder ssh" to replace"coder vscodessh".This change adds --network-info-dir and --network-info-interval flags tothe ssh subcommand. These were formerly only available with thevscodessh subcommand.Subsequent PRs will add a --ssh-host-prefix flag to the ssh subcommand,and adjust the log file naming to contain the parent PID.
d43228c
to9ff3342
Comparebcpeinhardt approved these changesJan 9, 2025
Uh oh!
There was an error while loading.Please reload this page.
838ee3b
intocoder:main 31 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PRs to enable
coder ssh
to replacecoder vscodessh
.This change adds
--network-info-dir
and--network-info-interval
flags to thessh
subcommand. These were formerly only available with thevscodessh
subcommand.Subsequent PRs will add a
--ssh-host-prefix
flag to the ssh subcommand, and adjust the log file naming to contain the parent PID.