Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: ensure active Organizations Page nav links are highlighted#16073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 4 commits intomainfromjaaydenh/navlink-bug
Jan 9, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedJan 8, 2025•
edited
Loading

Normally the react router Navlink should normalize the url path and match with or without a / on the end of the path.

This is a fix to use useMatch() to explicitly see if the current path is a match to an href to determine whether to apply active styling to the navlink

@jaaydenhjaaydenh self-assigned thisJan 8, 2025
@jaaydenhjaaydenh marked this pull request as ready for reviewJanuary 8, 2025 21:27
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good to go. Just had two small recommendations

@jaaydenhjaaydenh merged commit630fd7c intomainJan 9, 2025
28 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/navlink-bug branchJanuary 9, 2025 22:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 9, 2025
@ParkreinerParkreiner changed the titlefix: navlink investigationfix: ensure active styling is applied consistently for Organizations pageJan 10, 2025
@ParkreinerParkreiner changed the titlefix: ensure active styling is applied consistently for Organizations pagefix: ensure active Organizations Page nav links are highlightedJan 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp