Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: bundle a local version of install.sh#16064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromlilac/local-cli-install
Jan 14, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJan 8, 2025•
edited
Loading

Closes#13548

This allows users to...

  • Install a CLI that is known to have the same version as the server binary
  • Install the CLI in air-gapped deployments while still getting to run a simple install script

You run something like...

curl -fsSL https://dev.coder.com/install.sh| sh

...and it'll download a "slim" Coder build (CLI only) from the server (which serves these under paths like /bin/coder-$os-$arch) and install it.

This script is based off of our existing install.sh script, and accepts many of the same arguments, but has been tailored to this narrower use case.

There's also some fancy machinery to insert the correct origin to download the binary from using"text/template"

@aslilacaslilac changed the titlefeat: bundle a local version of install.sh, add CLI install pagefeat: bundle a local version of install.shJan 13, 2025
@aslilacaslilacforce-pushed thelilac/local-cli-install branch from2f9c32c tobb5f5f2CompareJanuary 13, 2025 18:46
@aslilacaslilac marked this pull request as ready for reviewJanuary 13, 2025 22:02
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great, nice work!

@aslilacaslilac merged commita450121 intomainJan 14, 2025
34 checks passed
@aslilacaslilac deleted the lilac/local-cli-install branchJanuary 14, 2025 18:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 14, 2025
@matifali
Copy link
Member

Another thing, while testing, I noticed this to be very slow compared to the install script we host on GitHub. It is probably a network-related thing, and our coder server may not have the same bandwidth as the GitHub CDNs.

@mafredri
Copy link
Member

mafredri commentedJan 16, 2025•
edited
Loading

@matifali it's (in part) because the command doesn't request compression. We could attempt a compressed transfer, but unfortunately that doesn't support a progress bar.

uncompressed (current)

/ # time curl -fL -o ~/.cache/coder/local_downloads/coder-linux-arm64-v2.18.2-devel+3a81aac31.incomplete -C - https://dev.coder.com/bin/coder-linux-arm64  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                 Dload  Upload   Total   Spent    Left  Speed100 36.2M  100 36.2M    0     0  3983k      0  0:00:09  0:00:09 --:--:-- 6951kreal0m 9.33suser0m 0.41ssys0m 0.49s

vs compressed:

/ # time curl --compressed -fL -o ~/.cache/coder/local_downloads/coder-linux-arm64-v2.18.2-devel+3a81aac31.incomplete -C - https://dev.coder.com/bin/coder-linux-arm64  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                 Dload  Upload   Total   Spent    Left  Speed100 12.6M    0 12.6M    0     0  3074k      0 --:--:--  0:00:04 --:--:-- 3204kreal0m 4.21suser0m 0.20ssys0m 0.09s

@matifali
Copy link
Member

Thanks,@mafredri, for investigating. My concern is that before we decide to make this the default behavior, we should ensure this doesn't cause a degradation in experience. I am fine if we lose the progress in favor of a faster download experience.

I have shared some thoughts here:#16125 (comment)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support targeting server binary in install script
3 participants
@aslilac@matifali@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp