Jan 7, 2025 · Jan 3, 2025 · Jan 3, 2025 · Jan 4, 2025 · Jan 4, 2025 · Jan 7, 2025
diff --git a/agent/proto/agent.pb.go b/agent/proto/agent.pb.go
diff --git a/agent/proto/agent.proto b/agent/proto/agent.proto
 }
 Health health = 12;
 bool hidden = 13;
 string open_in = 14;
 }

 message WorkspaceAgentScript {
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/database/db2sdk/db2sdk.go b/coderd/database/db2sdk/db2sdk.go
 },
 Health: codersdk.WorkspaceAppHealth(dbApp.Health),
 Hidden: dbApp.Hidden,
 OpenIn: codersdk.WorkspaceAppOpenIn(dbApp.OpenIn),
 })
 }
 return apps
diff --git a/codersdk/agentsdk/convert.go b/codersdk/agentsdk/convert.go
 },
 Health: health,
 Hidden: protoApp.Hidden,
 OpenIn: protoApp.OpenIn,
 }, nil
 }

 },
 Health: proto.WorkspaceApp_Health(health),
 Hidden: a.Hidden,
 OpenIn: a.OpenIn,
 }, nil
 }

diff --git a/codersdk/workspaceapps.go b/codersdk/workspaceapps.go
 WorkspaceAppSharingLevelPublic        WorkspaceAppSharingLevel = "public"
 )

 var MapWorkspaceAppSharingLevels = map[WorkspaceAppSharingLevel]struct{}{
 WorkspaceAppSharingLevelOwner:         {},
 WorkspaceAppSharingLevelAuthenticated: {},
 WorkspaceAppSharingLevelPublic:        {},
 }

 type WorkspaceAppOpenIn string

 const (
 WorkspaceAppOpenInTab        WorkspaceAppOpenIn = "tab"
 )

 varMapWorkspaceAppSharingLevels = map[WorkspaceAppSharingLevel]struct{}{
 WorkspaceAppSharingLevelOwner: {},
 WorkspaceAppSharingLevelAuthenticated: {},
 WorkspaceAppSharingLevelPublic:        {},
 varMapWorkspaceAppOpenIns = map[WorkspaceAppOpenIn]struct{}{
 WorkspaceAppOpenInSlimWindow: {},
 WorkspaceAppOpenInWindow: {},
 WorkspaceAppOpenInTab:        {},
 }

 type WorkspaceApp struct {
 Healthcheck Healthcheck        `json:"healthcheck"`
 Health      WorkspaceAppHealth `json:"health"`
 Hidden      bool               `json:"hidden"`
 OpenInstring `json:"open_in"`
 OpenInWorkspaceAppOpenIn `json:"open_in"`
 }

 type Healthcheck struct {
diff --git a/docs/reference/api/agents.md b/docs/reference/api/agents.md
diff --git a/docs/reference/api/builds.md b/docs/reference/api/builds.md
diff --git a/docs/reference/api/schemas.md b/docs/reference/api/schemas.md
Original file line number	Diff line number	Diff line change
Expand Up		@@ -42,7 +42,6 @@ message WorkspaceApp {
		}
		Health health = 12;
		bool hidden = 13;
		string open_in = 14;
		}

		message WorkspaceAgentScript {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -518,6 +518,7 @@ func Apps(dbApps []database.WorkspaceApp, agent database.WorkspaceAgent, ownerNa
		},
		Health: codersdk.WorkspaceAppHealth(dbApp.Health),
		Hidden: dbApp.Hidden,
		OpenIn: codersdk.WorkspaceAppOpenIn(dbApp.OpenIn),
Copy link ContributorAuthor defelmnqJan 7, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This piece is the most important of the PR - basically extracting data from the db to make them be visible in the SDK and API calls.
		})
		}
		return apps
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -255,7 +255,6 @@ func AppFromProto(protoApp *proto.WorkspaceApp) (codersdk.WorkspaceApp, error) {
		},
		Health: health,
		Hidden: protoApp.Hidden,
		OpenIn: protoApp.OpenIn,
		}, nil
		}

Expand DownExpand Up		@@ -286,7 +285,6 @@ func ProtoFromApp(a codersdk.WorkspaceApp) (*proto.WorkspaceApp, error) {
		},
		Health: proto.WorkspaceApp_Health(health),
		Hidden: a.Hidden,
		OpenIn: a.OpenIn,
		}, nil
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -28,6 +28,12 @@ const (
		WorkspaceAppSharingLevelPublic WorkspaceAppSharingLevel = "public"
		)

		var MapWorkspaceAppSharingLevels = map[WorkspaceAppSharingLevel]struct{}{
		WorkspaceAppSharingLevelOwner: {},
		WorkspaceAppSharingLevelAuthenticated: {},
		WorkspaceAppSharingLevelPublic: {},
		}

		type WorkspaceAppOpenIn string

		const (
Expand All		@@ -36,10 +42,10 @@ const (
		WorkspaceAppOpenInTab WorkspaceAppOpenIn = "tab"
		)

		varMapWorkspaceAppSharingLevels = map[WorkspaceAppSharingLevel]struct{}{
		WorkspaceAppSharingLevelOwner: {},
		WorkspaceAppSharingLevelAuthenticated: {},
		WorkspaceAppSharingLevelPublic: {},
		varMapWorkspaceAppOpenIns = map[WorkspaceAppOpenIn]struct{}{
		WorkspaceAppOpenInSlimWindow: {},
		WorkspaceAppOpenInWindow: {},
		WorkspaceAppOpenInTab: {},
		}

		type WorkspaceApp struct {
Expand DownExpand Up		@@ -70,7 +76,7 @@ type WorkspaceApp struct {
		Healthcheck Healthcheck `json:"healthcheck"`
		Health WorkspaceAppHealth `json:"health"`
		Hidden bool `json:"hidden"`
		OpenInstring `json:"open_in"`
		OpenInWorkspaceAppOpenIn `json:"open_in"`
		}

		type Healthcheck struct {
Expand Down