- Notifications
You must be signed in to change notification settings - Fork924
feat(cli): add provisioner list and provisioner jobs list#16030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 3, 2025
5edf87e to90a2e64Compare346ca29 toebaf498Compare90a2e64 to90f19d1Compareebaf498 toed828f6Compare180bf45 to4dcb7cbCompareed828f6 to8bee6f5Compare4dcb7cb to10475ccCompare8bee6f5 tod76be47Compare| var got bytes.Buffer | ||
| inv, root := clitest.New(t, | ||
| "provisioners", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is itprovisioners orprovisioner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The end goal is to showprovisioners in the help for consistency with our other commands. I think you mentioned to move the rename from provisioner -> provisioners to a follow-up PR in#15940 so I implemented it here. Since it's aliased it doesn't really matter what the test calls out, so it'll be one less change in the follow-up PR.
| return cmd | ||
| } | ||
| func (r *RootCmd) provisionerList() *serpent.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sane question
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
johnstcn approved these changesJan 7, 2025
mtojek approved these changesJan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ready to merge 👍
10475cc toc1a8874Comparee4b4e2f tod967f4bCompare555f4f3 to33fc30dCompared967f4b tob1fbc82Compare8726bd9 to3dcee5eCompare5633448 to4bc3559Compare3dcee5e to4c5b63bComparea37b1bd toc924457Compare4c5b63b tob28a888Comparec924457 to9525abdCompareb28a888 to965d618Compare9525abd to51f628cCompare965d618 to737d4b1Compare51f628c to1b40a44Compare737d4b1 toef7b2ebCompareb6eb60d to8d5fca2Compare504fc08 tod36df1aComparedd49c08 to0fd9aa7Compare Base automatically changed frommafredri/feat-coderd-provisioner-jobs-list tomainJanuary 20, 2025 09:18
d36df1a toa8dd9a1Comparea8dd9a1 tob9fc3a4Comparec0db364 intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Stack:
feat(cli): add provisioner list and provisioner jobs list
Closes#15191
Updates#15084
Supercedes#15940
(The column ordering in the tables is not ideal, I've created a follow-up issue for that:#16055.)