- Notifications
You must be signed in to change notification settings - Fork928
feat: added error boundary#1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Sorry for the drive-by comment on a merged PR, just happened across this and wondered if you had considered pre-filling out the email via E.g.: Just a thought, if this seems like a good idea I can open an issue about it. 👍🏻 |
@mafredri it's not merged yet! That's a good idea - I'll add this morning. |
Whoops!
|
| @@ -42,6 +42,7 @@ | |||
| "react": "17.0.2", | |||
| "react-dom": "17.0.2", | |||
| "react-router-dom": "6.3.0", | |||
| "sourcemapped-stacktrace": "1.1.11", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
praise: Thanks for pinning this!
| </XServiceProvider> | ||
| <ThemeProvider theme={dark}> | ||
| <CssBaseline /> | ||
| <ErrorBoundary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Praise: I love that theErrorBoundary doesn't have to care about theXServiceProvider, it's good to keep these non-reliant on each other!
| </XServiceProvider> | ||
| <ThemeProvider theme={dark}> | ||
| <CssBaseline /> | ||
| <ErrorBoundary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Praise: I love that theErrorBoundary doesn't have to care about theXServiceProvider, it's good to keep these non-reliant on each other!
Nicely done 🌮 |
* added error boundary and error ui components* add body txt and standardize btn size* added story* feat: added error boundarycloses#1013* committing lockfile* added email body to help link
Uh oh!
There was an error while loading.Please reload this page.
closes#1013