- Notifications
You must be signed in to change notification settings - Fork925
chore: only run pnpm when node_modules are out of date in Makefile#16017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for doing it Kayla. But please hold it till I merge the docs linting PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 OK to merge after Atif's PR is in.
d003767 intomainUh oh!
There was an error while loading.Please reload this page.
Even on a no-op,
pnpm itakesat least a full second to run and exit, which is a significant delay compared to the ~200ms that Biome itself takes to format our entire codebase.Sneaking in a timestamp file is a simple way to save a bit of time when running certain
makecommands that depend on npm packages.