- Notifications
You must be signed in to change notification settings - Fork914
chore: add spinner component#16014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jaaydenh commentedJan 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@BrunoQuaresma Im curious why not just use the Radix spinner component directly? For example, the Radix spinner has a bit of a better style because of the thicker lines and matches the Figma design a bit better. |
Uh oh!
There was an error while loading.Please reload this page.
Because it’s not a primitive—we’d have to install the entireRadix UI package along withtheir setup. |
Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
…oder into bq/add-spinner-component
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
…oder into bq/add-spinner-component
cee3656 intomainUh oh!
There was an error while loading.Please reload this page.
This component is necessary to move forward with the "Define a global button style" issue, as it requires buttons to support loading states with spinners. The
Spinnercomponent is heavily inspired by theRadix UI Spinner component and was developed with the help ofv0.Preview
