Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: document issue with direnv and nix-shell on macOS#15990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

paulroub
Copy link
Contributor

Including the suggested -- and tested -- workaround and a link to the direnv issue.

Including the suggested -- and tested -- workaround and a link to the direnv issue.
@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelDec 31, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedDec 31, 2024
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@paulroubpaulroub changed the titleNote current problem with direnv and nix-shell with macOSdocs: Note current problem with direnv and nix-shell with macOSDec 31, 2024
@paulroubpaulroub changed the titledocs: Note current problem with direnv and nix-shell with macOSdocs: note current problem with direnv and nix-shell with macOSDec 31, 2024
@paulroubpaulroub changed the titledocs: note current problem with direnv and nix-shell with macOSdocs: document issue with direnv and nix-shell on macOSDec 31, 2024
@paulroub
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull requestDec 31, 2024
@matifalimatifali requested a review frommtojekJanuary 1, 2025 10:53
🎉
```

>**Note:** On macOS, a[direnv bug](https://github.com/direnv/direnv/issues/1345) can cause`nix-shell` to fail to build or run`coder`. If you see`error: creating directory` when attempting to run, build, or test, adding one line to your`.envrc` should fix the problem:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Honestly, I would create a subsection for Troubleshooting and mention this issue. Otherwise, there is a risk we'll end up with 10 notes referring different issues.

I'll defer the final decision to@EdwardAngert 👍

EdwardAngert reacted with thumbs up emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks@paulroub ! I do agree with@mtojek , but there are a few more (unrelated) things I want to edit in this doc. I'll approve this as is, and follow-up in a little while

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a trick (beyond commenting "recheck", which isn't doing it) to have thecontrib / cla check redone?

Copy link
Contributor

@EdwardAngertEdwardAngertJan 2, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It might just be busted,@paulroub

I had this issue with some of my own PRs - some I was able to fix when I confirmed my git config user and email (pasting below, just in case), and some just still fail. We're working on figuring out why and fixing it, but it's not a required check for us to merge

git config --local user.name"myusername"&& \git config --local user.email"no-reply-email+myusername@users.noreply.github.com"

edit: scratch that - looks like you've been added incoder/cla@061cd21

@EdwardAngert
Copy link
Contributor

I'm changing the base branch so that I can test some linting and add some edits on that branch

@EdwardAngertEdwardAngert changed the base branch frommain to15990-contrib-nix-shellJanuary 2, 2025 17:47
@EdwardAngertEdwardAngert merged commitd10d9b5 intocoder:15990-contrib-nix-shellJan 2, 2025
16 of 21 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 2, 2025
@paulroubpaulroub deleted the patch-1 branchJanuary 2, 2025 18:26
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mtojekmtojekmtojek left review comments

+1 more reviewer

@EdwardAngertEdwardAngertEdwardAngert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulroubpaulroub

Labels

communityPull Requests and issues created by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulroub@EdwardAngert@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp