Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add Collapsible component#15961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 4 commits intomainfrombq/add-collapsible
Dec 26, 2024
Merged

Conversation

@BrunoQuaresma
Copy link
Contributor

This component is needed to complete the mobile menu for thenavbar refactoring task. You can check out the Figma designhere.

@BrunoQuaresmaBrunoQuaresma requested review froma team andaqandrew and removed request fora teamDecember 26, 2024 17:56
Copy link
Contributor

@aqandrewaqandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is just the result of runningpnpm dlx shadcn@latest add collapsible from the shadcn docs, right?

If so then lgtm! I haven't cloned this repo / run Storybook locally yet. I assume you'll adjust the chevron icons +CollapsibleContent indentation for the mobile nav in a separate PR

BrunoQuaresma reacted with thumbs up emoji
Copy link
Contributor

@buenos-nachosbuenos-nachos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@BrunoQuaresmaBrunoQuaresma merged commit8659694 intomainDec 26, 2024
29 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-collapsible branchDecember 26, 2024 19:03
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aqandrewaqandrewaqandrew approved these changes

+1 more reviewer

@buenos-nachosbuenos-nachosbuenos-nachos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrunoQuaresma@aqandrew@buenos-nachos

[8]ページ先頭

©2009-2025 Movatter.jp