- Notifications
You must be signed in to change notification settings - Fork1k
chore: remove docker host from docker-compose#1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| # Use the docker gateway if the access URL is 127.0.0.1 | ||
| command=["sh","-c",replace(coder_agent.dev.init_script,"127.0.0.1","host.docker.internal")] | ||
| env=["CODER_AGENT_TOKEN=${coder_agent.dev.token}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kylecarbs@johnstcn This feels hacky, but seems to address all scenarios:
- ✅ Proper access URL (https://127.0.0.1:7080) on
coder server"welcome" message - ✅ docker-compose examplejust works with Docker examples
- ✅ Non docker-compose deployments with a proper access URL remain working with the Docker example (no hardcoded values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this is too bad. 👍
| command=["sh","-c",coder_agent.dev.init_script] | ||
| env=["CODER_AGENT_TOKEN=${coder_agent.dev.token}"] | ||
| # Use the docker gateway if the access URL is 127.0.0.1 | ||
| command=["sh","-c",replace(coder_agent.dev.init_script,"127.0.0.1","host.docker.internal")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Uh oh!
There was an error while loading.Please reload this page.
There isn't really a great solution to get docker-compose working locally:
❌ use 127.0.0.1 as access URL for docker
❌ use
--network=hoston containers in the template:8080❌ add host.docker.internal to docker-compose:
coder servercommand❌ add host.docker.internal to the Docker templates.
🤔 admin parameter for access URL in Docker templates
✅ this hack (override and replace localhost access URL in Docker start script)