Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: provide useful debug info when retrieving a version from GitHub fails#15956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intomainfromdk/install
Jan 9, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedDec 24, 2024•
edited
Loading

Closes#15851

This fails the installation when the version cannot be retrieved, and prints useful debug info.

install.sh could use with more error-handling in general, but this at least ameliorates the linked issue.

@dannykoppingdannykopping changed the titlePrint useful debug info when retrieving a version from GitHub failsfix: print useful debug info when retrieving a version from GitHub failsDec 24, 2024
@dannykoppingdannykopping marked this pull request as ready for reviewDecember 24, 2024 15:58
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definitely not a Bash expert, but if Cian can't get to this by tomorrow morning, I'll get up to speed on the syntax and trudge through things tomorrow

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Went through everything, and it looks good. Sorry I didn't get this approved earlier today

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJan 6, 2025
@dannykoppingdannykopping changed the titlefix: print useful debug info when retrieving a version from GitHub failsprovide useful debug info when retrieving a version from GitHub failsJan 9, 2025
@dannykoppingdannykoppingenabled auto-merge (squash)January 9, 2025 09:46
@dannykoppingdannykopping changed the titleprovide useful debug info when retrieving a version from GitHub failsfix: provide useful debug info when retrieving a version from GitHub failsJan 9, 2025
@dannykoppingdannykopping merged commit401f8b4 intomainJan 9, 2025
33 of 34 checks passed
@dannykoppingdannykopping deleted the dk/install branchJanuary 9, 2025 09:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@dannykoppingdannykopping

Labels

staleThis issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

install.sh script intermittently fails when trying to fetch releases from GitHub API

3 participants

@dannykopping@johnstcn@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp