Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(examples/templates/digitalocean-linux): make template more friendly#15938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phorcys420 merged 6 commits intomainfromphorcys/improve-digitalocean-template
Dec 24, 2024

Conversation

@phorcys420
Copy link
Member

@phorcys420phorcys420 commentedDec 19, 2024•
edited
Loading

This PR aims to make the DigitalOcean Linux template more user friendly for first-time users.

@phorcys420phorcys420 marked this pull request as draftDecember 19, 2024 15:06
@phorcys420
Copy link
MemberAuthor

@matifali I think we should let template admins set the DigitalOcean token as a template variable instead of enforcing only theDIGITALOCEAN_TOKEN variable, what do you think?

@matifali
Copy link
Member

@phorcys420 Can we make the variable optional and only ask if there is noDIGITALOCEAN_TOKEN?

@phorcys420
Copy link
MemberAuthor

@matifali we can make it optional but i don't think we can hide it based on an env variable, i will try

matifali reacted with thumbs up emoji

@phorcys420phorcys420 changed the titlephorcys/improve digitalocean templatechore(digitalocean-linux): promote module usageDec 21, 2024
@phorcys420phorcys420 changed the titlechore(digitalocean-linux): promote module usagefeat(examples/templates/digitalocean-linux): switch code-server to a module and add JetBrainsDec 23, 2024
@phorcys420phorcys420 changed the titlefeat(examples/templates/digitalocean-linux): switch code-server to a module and add JetBrainschore(examples/templates/digitalocean-linux): make template more friendlyDec 23, 2024
@phorcys420phorcys420 requested review frommafredri andspikecurtis and removed request formafredriDecember 23, 2024 21:09
@phorcys420
Copy link
MemberAuthor

Tested on dogfood viarelaxed_hamilton6 (token revoked)

@phorcys420phorcys420 marked this pull request as ready for reviewDecember 23, 2024 21:11
@phorcys420phorcys420enabled auto-merge (squash)December 23, 2024 21:11
@phorcys420phorcys420force-pushed thephorcys/improve-digitalocean-template branch from63684e3 to47a3808CompareDecember 23, 2024 21:12
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@phorcys420phorcys420 merged commit03edd60 intomainDec 24, 2024
30 checks passed
@phorcys420phorcys420 deleted the phorcys/improve-digitalocean-template branchDecember 24, 2024 19:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifalimatifali approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@phorcys420phorcys420

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phorcys420@matifali
[8]ページ先頭
©2009-2025 Movatter.jp