Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use docker host in docker-compose#1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 3 commits intomainfrombpmct/docker-vars
May 19, 2022
Merged

Conversation

bpmct
Copy link
Member

@bpmctbpmct commentedMay 19, 2022•
edited
Loading

This PR adds support for passing throughCODER_ACCESS_URL in docker-compose, and also defaults to the docker host.

This is somewhat a revert of#1507, but it was also its initial implementation. I think this is an acceptable standard for the following reasons:

  • The absence of an access URL in docker-compose results in 0 functioning example templates
  • The docker host as an access URL in docker-compose results in 2 functioning example templates (docker, docker-builds)
  • Users will be required to set an access URL anyways to use all other example templates.Warn users if their access URL is localhost or 127.0.0.1 #1528 proposes a warning for this anyways
  • Docker template users will not experience breaking changes if they have a functional access URL (this already happened!)

Related discussions:#1545,#1528,#1345,#1545

@bpmctbpmct self-assigned thisMay 19, 2022
@@ -1,12 +1,15 @@
version: "3.9"
services:
coder:
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.6}-${ARCH:-amd64}
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.10}-${ARCH:-amd64}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wishdependabot/dependabot-core#390 existed. Maybe we use Renovate or another tool?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we've even got0.5.11 right now!

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it seems the release was deleted:https://github.com/coder/coder/releases/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fair point then!

@bpmctbpmct requested a review fromjohnstcnMay 19, 2022 16:10
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm completely happy with this approach instead.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Superb! 🎉

@bpmctbpmct merged commitc47b6f0 intomainMay 19, 2022
@bpmctbpmct deleted the bpmct/docker-vars branchMay 19, 2022 16:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mafredrimafredrimafredri approved these changes

Assignees

@bpmctbpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@bpmct@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp