- Notifications
You must be signed in to change notification settings - Fork1k
chore: record and raise problematic http protocols for each proxy#15917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
site/src/pages/UserSettingsPage/WorkspaceProxyPage/WorkspaceProxyRow.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| `Requests to the proxy are using${latency.nextHopProtocol}, `+ | ||
| "the server might not support HTTP/2. "+ | ||
| "For usability reasons, HTTP/2 or above is recommended. "+ | ||
| "Pages may fail to load if the web browser's concurrent "+ | ||
| "connection limit is reached.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I find this description really unclear. Requests to the proxy from where? What server? Why is there a comma separating what feels like two sentences? I think this needs a bit more refinement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How about:
`Requests to the proxy from current browser are using "${latency.nextHopProtocol}". ` +"The proxy server might not support HTTP/2. " +"For usability reasons, HTTP/2 or above is recommended. " +"Pages may fail to load if the web browser's concurrent " +"connection limit per host is reached.",Uh oh!
There was an error while loading.Please reload this page.
6e021b6 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closes#15887
Adds warnings to the proxy and proxy health pages on HTTP 1.1, 1.0, 0.9 protocols.
Implementation notes
Only the performance API can return the HTTP protocol type. We already use the performance API for latency timings, and each proxy could have this issue. So it made the most sense to put the warnings here.
Imo we should raise this error to admins more seriously and obviously, but that can wait.