- Notifications
You must be signed in to change notification settings - Fork1k
chore: remove apitypings specific go.mod#15899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emyrk commentedDec 17, 2024
Uh oh!
There was an error while loading.Please reload this page.
@Parkreiner added you for the TS types |
Keeping the deps in sync between this and the primary go.mod isa headache. Share the go.mod so we can reference all the correcttypes.
a3cf00a to181f379Comparespikecurtis approved these changesDec 18, 2024
13bb449 intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Keeping the deps in sync between this and the primary go.mod is
a headache. Share the go.mod so we can reference all the correct
types.
It was done originally to keep
gojaout of the primary go.mod, and becausegutswas on Go 1.23. Guts was fixed to be on the same go version ascoder/coder:coder/guts#11Also adds Tailscale generated types (3414366)
Closescoder/internal#255