Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: migrate to coder/websocket 1.8.12#15898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/coder-websocket
Dec 18, 2024

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedDec 17, 2024•
edited
Loading

Migrates us tocoder/websocket v1.8.12 rather thannhooyr/websocket on an older version.

Works aroundcoder/websocket#504 by adding an explicit test forxerrors.Is(err, io.EOF) where we were previously gettingio.EOF from the netConn.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewDecember 17, 2024 12:59
@spikecurtisspikecurtis changed the titlemigrate to coder/websocket 1.8.12[chore] migrate to coder/websocket 1.8.12Dec 17, 2024
Copy link
Member

@mafredrimafredri left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we updatecoder/tailscale at the same time so that we don't run two versions of websocket?

I did some testing against bothcoder/tailscale andcoder/coder while working oncoder/websocket#476 and didn't notice any glaring issues so stamping this PR (even though it does not include said fix).

@spikecurtis
Copy link
ContributorAuthor

Should we updatecoder/tailscale at the same time so that we don't run two versions of websocket?

I did some testing against bothcoder/tailscale andcoder/coder while working oncoder/websocket#476 and didn't notice any glaring issues so stamping this PR (even though it does not include said fix).

coder/tailscale got updated incoder/tailscale#65 and this moves us to that commit.

mafredri reacted with hooray emoji

@spikecurtisspikecurtis changed the title[chore] migrate to coder/websocket 1.8.12chore: migrate to coder/websocket 1.8.12Dec 18, 2024
@spikecurtisspikecurtis merged commit2c7f8ac intomainDec 18, 2024
34 checks passed
@spikecurtisspikecurtis deleted the spike/coder-websocket branchDecember 18, 2024 20:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spikecurtis@mafredri@deansheather@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp