- Notifications
You must be signed in to change notification settings - Fork926
chore: allow signing in as non-admin users in e2e tests#15892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6abe5f6 to0dbd385Compare@aslilac could you add a description to the PR to provider more information about the goal of this PR? From what I can tell, its adds a helper so that the login can happen but its always using the admin user credentials from constants.ts. So is this enabling future changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
962608c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#168
Gets rid of the "global state" authentication, and adds a
loginhelper which should be called at the beginning of each test. This means that not every test needs to authenticated as admin, and we can even have tests that encompass multiple permission levels.We also now create more than just the single admin user during setup, so that we can have a set of users to pick from as appropriate.