- Notifications
You must be signed in to change notification settings - Fork1k
chore: acquire lock for individual workspace transition#15883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When Coder is ran in High Availability mode, each Coder instance has alifecycle executor. These lifecycle executors are all trying to do thesame work, and whilst transactions saves us from this causing an issue,we are still doing extra work that could be prevented.This PR adds a `TryAcquireLock` call for each attempted workspacetransition, meaning two Coder instances shouldn't duplicate effort.(cherry picked from commit50ff06c)
matifali approved these changesDec 16, 2024
c5e8769 intorelease/2.18 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Coder is ran in High Availability mode, each Coder instance has a lifecycle executor. These lifecycle executors are all trying to do the same work, and whilst transactions saves us from this causing an issue, we are still doing extra work that could be prevented.
This PR adds a
TryAcquireLockcall for each attempted workspace transition, meaning two Coder instances shouldn't duplicate effort.(cherry picked from commit50ff06c)