Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: encode.dockerconfigjson value for kubernetes-devcontainer example template#15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intocoder:mainfromduchuyvp:patch-1
Dec 16, 2024
Merged

Conversation

@duchuyvp
Copy link
Contributor

@duchuyvpduchuyvp commentedDec 11, 2024•
edited
Loading

Value of.dockerconfigjson in kubernetes_secret datasource is already decoded, so I encode it again to avoid error forENVBUILDER_DOCKER_CONFIG_BASE64

@cdr-botcdr-botbot added the communityPull Requests and issues created by the community. labelDec 11, 2024
@duchuyvpduchuyvp changed the titleFix ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example templatefix: encode ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example templateDec 11, 2024
@duchuyvpduchuyvp changed the titlefix: encode ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example templatefix: encode.dockerconfigjson value for kubernetes-devcontainer example templateDec 11, 2024
@duchuyvp
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actionsbot commentedDec 11, 2024•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@duchuyvp
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

@duchuyvp
Copy link
ContributorAuthor

recheck

@johnstcn
Copy link
Member

@duchuyvp Sorry, something's up with our CLA. We're looking into it.

duchuyvp reacted with heart emoji

cdrci2 added a commit to coder/cla that referenced this pull requestDec 11, 2024
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for catching this@duchuyvp!
In the process of testing this change, I also uncovered some separate issues. I'll submit some separate PRs for those.

@duchuyvp
Copy link
ContributorAuthor

@johnstcn that's good.

@johnstcnjohnstcn merged commit2eee201 intocoder:mainDec 16, 2024
38 of 42 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@duchuyvpduchuyvp

Labels

communityPull Requests and issues created by the community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@duchuyvp@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp