Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: skip running test-e2e on PRs from forks#15784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 4 commits intomainfromatif/skip-e2e-premium-forks
Dec 9, 2024

Conversation

matifali
Copy link
Member

@matifalimatifali commentedDec 9, 2024•
edited
Loading

A workaround for#15557. We will come up with a more permanent solution

Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifalimatifalienabled auto-merge (squash)December 9, 2024 09:16
@matifali
Copy link
MemberAuthor

matifali commentedDec 9, 2024•
edited
Loading

@deansheather looks like matrix context is not available at job level.

[Invalid workflow file: .github/workflows/ci.yaml#L644](https://github.com/coder/coder/actions/runs/12232484795/workflow)The workflow is not valid. .github/workflows/ci.yaml (Line: 644, Col: 9): Unrecognized named-value: 'matrix'. Located at position 198 within expression: (needs.changes.outputs.go == 'true' || needs.changes.outputs.ts == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main') && !(github.event.pull_request.head.repo.fork && matrix.variant.premium)

We can either move the condition to all individual steps or skip both e2e and e2e-premium tests.

@deansheather
Copy link
Member

@matifali maybe just make it skip e2e entirely for now to unblock external contributions, and we can prioritise coming up with a solution (like generating short licenses each time)

matifali reacted with thumbs up emoji

@matifalimatifali changed the titleci: skip running test-e2e-premium on PRs from forksci: skip running test-e2e on PRs from forksDec 9, 2024
@matifalimatifalienabled auto-merge (squash)December 9, 2024 09:45
@matifalimatifali merged commit901ad3f intomainDec 9, 2024
33 checks passed
@matifalimatifali deleted the atif/skip-e2e-premium-forks branchDecember 9, 2024 09:50
aslilac pushed a commit that referenced this pull requestDec 11, 2024
Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifalimatifali linked an issueJan 3, 2025 that may beclosed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forks are unable to run ci because no access to secrets
3 participants
@matifali@deansheather@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp