- Notifications
You must be signed in to change notification settings - Fork926
fix: update workspace TTL on template TTL change#15761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aa0b769 to021a806Compare
mafredri left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, only minor suggestions/nits.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
40624bf intomainUh oh!
There was an error while loading.Please reload this page.
Relates to#15390Currently when a user creates a workspace, their workspace's TTL isdetermined by the template's default TTL. If the Coder instance is AGPL,or if the template has disallowed the user from configuring autostop,then it is not possible to change the workspace's TTL after creation.Any changes to the template's default TTL only takes effect on _new_workspaces.This PR modifies the behaviour slightly so that on AGPL Coder, or onenterprise when a template does not allow user's to configure theirworkspace's TTL, updating the template's default TTL will also updateany workspace's TTL to match this value.
Relates to#15390
Currently when a user creates a workspace, their workspace's TTL is determined by the template's default TTL. If the Coder instance is AGPL, or if the template has disallowed the user from configuring autostop, then it is not possible to change the workspace's TTL after creation. Any changes to the template's default TTL only takes effect onnew workspaces.
This PR modifies the behaviour slightly so that on AGPL Coder, or on enterprise when a template does not allow user's to configure their workspace's TTL, updating the template's default TTL will also update any workspace's TTL to match this value.