- Notifications
You must be signed in to change notification settings - Fork926
fix: remove backtick from valid password characters#15756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Since backticks are the PowerShell escape character, they are silently consumed. To actually use backticks, they would need to be doubled when used.
matifali approved these changesDec 6, 2024
Member
matifali left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks for catching and fixing it.
bae12e1 intomain 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
aslilac pushed a commit that referenced this pull requestDec 11, 2024
Since backticks are the PowerShell escape character, they are silentlyconsumed. To actually use backticks, they would need to be doubled whenused.This change increases the safety of generated passwords for otherterraform modules that might use this value unawares.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
bug riskProne to bugs customer-reportedBugs reported by enterprise customers. Only humans may set this. s3Bugs that confuse, annoy, or are purely cosmetic
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since backticks are the PowerShell escape character, they are silently consumed. To actually use backticks, they would need to be doubled when used.
This change increases the safety of generated passwords for other terraform modules that might use this value unawares.