Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add OpenIn option to coder_app#15743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
defelmnq merged 29 commits intomainfromcoder_app-open_in
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
29 commits
Select commitHold shift + click to select a range
5483426
work on OpenIn implementation
defelmnqDec 4, 2024
1752f40
improve open_in parameter handling
defelmnqDec 4, 2024
0e69ff4
Update provisioner.proto
defelmnqDec 4, 2024
bd9d40b
add open_in logic
defelmnqDec 17, 2024
8596e92
add open_in logic
defelmnqDec 17, 2024
9a99df5
Merge remote-tracking branch 'origin/main' into coder_app-open_in
defelmnqDec 17, 2024
451bf3b
up generated doc
defelmnqDec 17, 2024
6b8858e
work on ts tests
defelmnqDec 18, 2024
90fd0e3
work on ts tests
defelmnqDec 18, 2024
5c207ec
work on tests for tf
defelmnqDec 18, 2024
803fe24
reset failing tests
defelmnqDec 18, 2024
82d4f8f
Merge remote-tracking branch 'origin/main' into coder_app-open_in
defelmnqDec 20, 2024
f97a385
bump go.mod
defelmnqDec 20, 2024
bfdaefd
merge
defelmnqDec 20, 2024
c6d18a6
change database type for enum
defelmnqDec 20, 2024
b81b84d
change database type for enum
defelmnqDec 20, 2024
05db2b7
Merge branch 'main' into coder_app-open_in
defelmnqDec 23, 2024
9a06745
up gomod
defelmnqDec 23, 2024
079e474
work on tests in dbmem
defelmnqDec 23, 2024
6e368bf
work on tests
defelmnqDec 23, 2024
1dec106
work on tests
defelmnqDec 23, 2024
54f3a70
increase minor version of provisioner api
defelmnqJan 3, 2025
5730ea0
Merge remote-tracking branch 'origin/main' into coder_app-open_in
defelmnqJan 3, 2025
8f76203
improve constant and code logic
defelmnqJan 3, 2025
4ca1aa0
increase migration idx
defelmnqJan 3, 2025
c64973d
Merge remote-tracking branch 'origin/main' into coder_app-open_in
defelmnqJan 3, 2025
4698162
increase migration idx
defelmnqJan 3, 2025
2122b3b
make gen
defelmnqJan 3, 2025
bb801f0
add version history in the provisioner version
defelmnqJan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
reset failing tests
  • Loading branch information
@defelmnq
defelmnq committedDec 18, 2024
commit803fe24bfaeadf21202d289649ab581a786c54b0
3 changes: 0 additions & 3 deletionsprovisioner/terraform/resources_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -182,7 +182,6 @@ func TestConvertResources(t *testing.T) {
DisplayName: "app1",
// Subdomain defaults to false if unspecified.
Subdomain: false,
OpenIn: "slim-window",
},
{
Slug: "app2",
Expand All@@ -193,13 +192,11 @@ func TestConvertResources(t *testing.T) {
Interval: 5,
Threshold: 6,
},
OpenIn: "window",
},
{
Slug: "app3",
DisplayName: "app3",
Subdomain: false,
OpenIn: "tab",
},
},
Auth: &proto.Agent_Token{},
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ resource "coder_app" "app1" {
slug = "app1"
# subdomain should default to false.
# subdomain = false
open_in = "slim-window"
}

# app2 tests that subdomaincan be true, and that healthchecks work.
Expand All@@ -31,15 +30,13 @@ resource "coder_app" "app2" {
interval = 5
threshold = 6
}
open_in = "window"
}

# app3 tests that subdomain can explicitly be false.
resource "coder_app" "app3" {
agent_id = coder_agent.dev1.id
slug = "app3"
subdomain = false
open_in = "tab"
}

resource "null_resource" "dev" {
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp