- Notifications
You must be signed in to change notification settings - Fork1k
fix: static data in mocks#1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will break Storybook. Time ago will always be changing! Is something broken rn?
Thisfixes Storybook,not breaks it. To understand why not have dynamic is causing a changeset in chromatic:https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=628544a245901b004586ba74 |
@vapurrmaid I believe this will fix that page, but break the Workspaces page timestamps in Storybook. |
@vapurrmaid it's probably best if Storybook page instances decide to use static vs. dynamic time themselves. Because there could be requirements to display |
Uh oh!
There was an error while loading.Please reload this page.
No description provided.