Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: static data in mocks#1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greyscaled merged 3 commits intomainfromvapurrmaid/static-mock-data
May 19, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

No description provided.

@greyscaledgreyscaled requested a review froma team as acode ownerMay 18, 2022 20:01
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will break Storybook. Time ago will always be changing! Is something broken rn?

@greyscaled
Copy link
ContributorAuthor

This will break Storybook. Time ago will always be changing! Is something broken rn?

Thisfixes Storybook,not breaks it.

To understand why not have dynamicnew Date()s in our mocks, see that@Emyrk 's PR that touches only the backend here:

#1569

is causing a changeset in chromatic:https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=628544a245901b004586ba74

@kylecarbs
Copy link
Member

@vapurrmaid I believe this will fix that page, but break the Workspaces page timestamps in Storybook.

@kylecarbs
Copy link
Member

@vapurrmaid it's probably best if Storybook page instances decide to use static vs. dynamic time themselves. Because there could be requirements to displayago on one page, and a specific timestamp on another, it seems like it'll be hard to standardize.

@greyscaledgreyscaled marked this pull request as draftMay 19, 2022 01:25
@greyscaledgreyscaled marked this pull request as ready for reviewMay 19, 2022 15:16
@greyscaledgreyscaled merged commite0165c5 intomainMay 19, 2022
@greyscaledgreyscaled deleted the vapurrmaid/static-mock-data branchMay 19, 2022 15:36
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs left review comments

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greyscaled@kylecarbs@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp