Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: fetch annotated tags during release/build-dylib#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/fix-release-dylib
Dec 4, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedDec 4, 2024
edited
Loading

The release actionran into an issue building the dylib today, as the version script that's run during the build job was unable to find an annotated tag. This is a step it skips during dry-runs.

ERROR: version.sh: the current commit is not tagged with an annotated tag

This was almost certainly caused by omitting thegit fetch --tags --force that's present on each other release action job, as the workflow passes on a release dry-run when run against a regular branch, that's not an annotated tag.

From an existing comment:

If the event that triggered the build was an annotated tag (which our
tags are supposed to be), actions/checkout has a bug where the tag in
question is only a lightweight tag and not a full annotated tag.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson changed the titlefix(ci): fetch annotated tags during release/build-dylibci: fetch annotated tags during release/build-dylibDec 4, 2024
@ethanndicksonethanndickson marked this pull request as ready for reviewDecember 4, 2024 00:15
@ethanndicksonethanndickson merged commit887ea14 intomainDec 4, 2024
48 checks passed
@ethanndicksonethanndickson deleted the ethan/fix-release-dylib branchDecember 4, 2024 08:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sreyasreyasreya approved these changes

@stirbystirbyAwaiting requested review from stirby

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@sreya

[8]ページ先頭

©2009-2025 Movatter.jp