- Notifications
You must be signed in to change notification settings - Fork935
chore: release cherry-picks for 2.18.0#15719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
12c4bb5
chore: track usage of built-in example templates (#15671)
hugodutkabf74f8b
feat(site): show license utilization in general settings (#15683)
SasSwart54f7605
feat(site): warn on provisioner health during builds (#15589)
SasSwartb359fb9
fix: fix goroutine leak in log streaming over websocket (#15709)
spikecurtis1d789ce
fix(coderd): ensure that clearing invalid oauth refresh tokens works …
johnstcnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
feat(site): warn on provisioner health during builds (#15589)
This PR adds warning alerts to log drawers for templates and templateversions. warning alerts for workspace builds to follow in a subsequentPR. Phrasing to be finalised. Stories added and manually verified. Seescreenshots below.Updating a template version with no provisioners:<img width="1250" alt="Screenshot 2024-11-27 at 11 06 28"src="https://github.com/user-attachments/assets/47aa0940-57a8-44e1-b9a3-25a638fa2c8d">Build Errors for template versions now show tags as well:<img width="1250" alt="Screenshot 2024-11-27 at 11 07 01"src="https://github.com/user-attachments/assets/566e5339-0fe1-4cf7-8eab-9bf4892ed28a">Updating a template version with provisioners that are busy orunresponsive:<img width="1250" alt="Screenshot 2024-11-27 at 11 06 40"src="https://github.com/user-attachments/assets/71977c8c-e4ed-457f-8587-2154850e7567">Creating a new template with provisioners that are busy or unresponsive:<img width="819" alt="Screenshot 2024-11-27 at 11 08 55"src="https://github.com/user-attachments/assets/bda11501-b482-4046-95c5-feabcd1ad7f5">Creating a new template when there are no provisioners to do the build:<img width="819" alt="Screenshot 2024-11-27 at 11 08 45"src="https://github.com/user-attachments/assets/e4279ebb-399e-4c6e-86e2-ead8f3ac7605">(cherry picked from commit56c792a)
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
10 changes: 9 additions & 1 deletionsite/src/api/api.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18 changes: 10 additions & 8 deletionssite/src/api/queries/organizations.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletionssite/src/components/Alert/Alert.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletionssite/src/modules/provisioners/ProvisionerAlert.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import type { Meta, StoryObj } from "@storybook/react"; | ||
import { chromatic } from "testHelpers/chromatic"; | ||
import { ProvisionerAlert } from "./ProvisionerAlert"; | ||
const meta: Meta<typeof ProvisionerAlert> = { | ||
title: "modules/provisioners/ProvisionerAlert", | ||
parameters: { | ||
chromatic, | ||
layout: "centered", | ||
}, | ||
component: ProvisionerAlert, | ||
args: { | ||
title: "Title", | ||
detail: "Detail", | ||
severity: "info", | ||
tags: { tag: "tagValue" }, | ||
}, | ||
}; | ||
export default meta; | ||
type Story = StoryObj<typeof ProvisionerAlert>; | ||
export const Info: Story = {}; | ||
export const NullTags: Story = { | ||
args: { | ||
tags: undefined, | ||
}, | ||
}; |
45 changes: 45 additions & 0 deletionssite/src/modules/provisioners/ProvisionerAlert.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import AlertTitle from "@mui/material/AlertTitle"; | ||
import { Alert, type AlertColor } from "components/Alert/Alert"; | ||
import { AlertDetail } from "components/Alert/Alert"; | ||
import { Stack } from "components/Stack/Stack"; | ||
import { ProvisionerTag } from "modules/provisioners/ProvisionerTag"; | ||
import type { FC } from "react"; | ||
interface ProvisionerAlertProps { | ||
title: string; | ||
detail: string; | ||
severity: AlertColor; | ||
tags: Record<string, string>; | ||
} | ||
export const ProvisionerAlert: FC<ProvisionerAlertProps> = ({ | ||
title, | ||
detail, | ||
severity, | ||
tags, | ||
}) => { | ||
return ( | ||
<Alert | ||
severity={severity} | ||
css={(theme) => { | ||
return { | ||
borderRadius: 0, | ||
border: 0, | ||
borderBottom: `1px solid ${theme.palette.divider}`, | ||
borderLeft: `2px solid ${theme.palette[severity].main}`, | ||
}; | ||
}} | ||
> | ||
<AlertTitle>{title}</AlertTitle> | ||
<AlertDetail> | ||
<div>{detail}</div> | ||
<Stack direction="row" spacing={1} wrap="wrap"> | ||
{Object.entries(tags ?? {}) | ||
.filter(([key]) => key !== "owner") | ||
.map(([key, value]) => ( | ||
<ProvisionerTag key={key} tagName={key} tagValue={value} /> | ||
))} | ||
</Stack> | ||
</AlertDetail> | ||
</Alert> | ||
); | ||
}; |
55 changes: 55 additions & 0 deletionssite/src/modules/provisioners/ProvisionerStatusAlert.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import type { Meta, StoryObj } from "@storybook/react"; | ||
import { chromatic } from "testHelpers/chromatic"; | ||
import { MockTemplateVersion } from "testHelpers/entities"; | ||
import { ProvisionerStatusAlert } from "./ProvisionerStatusAlert"; | ||
const meta: Meta<typeof ProvisionerStatusAlert> = { | ||
title: "modules/provisioners/ProvisionerStatusAlert", | ||
parameters: { | ||
chromatic, | ||
layout: "centered", | ||
}, | ||
component: ProvisionerStatusAlert, | ||
args: { | ||
matchingProvisioners: 0, | ||
availableProvisioners: 0, | ||
tags: MockTemplateVersion.job.tags, | ||
}, | ||
}; | ||
export default meta; | ||
type Story = StoryObj<typeof ProvisionerStatusAlert>; | ||
export const HealthyProvisioners: Story = { | ||
args: { | ||
matchingProvisioners: 1, | ||
availableProvisioners: 1, | ||
}, | ||
}; | ||
export const UndefinedMatchingProvisioners: Story = { | ||
args: { | ||
matchingProvisioners: undefined, | ||
availableProvisioners: undefined, | ||
}, | ||
}; | ||
export const UndefinedAvailableProvisioners: Story = { | ||
args: { | ||
matchingProvisioners: 1, | ||
availableProvisioners: undefined, | ||
}, | ||
}; | ||
export const NoMatchingProvisioners: Story = { | ||
args: { | ||
matchingProvisioners: 0, | ||
}, | ||
}; | ||
export const NoAvailableProvisioners: Story = { | ||
args: { | ||
matchingProvisioners: 1, | ||
availableProvisioners: 0, | ||
}, | ||
}; |
47 changes: 47 additions & 0 deletionssite/src/modules/provisioners/ProvisionerStatusAlert.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
importtype{AlertColor}from"components/Alert/Alert"; | ||
importtype{FC}from"react"; | ||
import{ProvisionerAlert}from"./ProvisionerAlert"; | ||
interfaceProvisionerStatusAlertProps{ | ||
matchingProvisioners:number|undefined; | ||
availableProvisioners:number|undefined; | ||
tags:Record<string,string>; | ||
} | ||
exportconstProvisionerStatusAlert:FC<ProvisionerStatusAlertProps>=({ | ||
matchingProvisioners, | ||
availableProvisioners, | ||
tags, | ||
})=>{ | ||
lettitle:string; | ||
letdetail:string; | ||
letseverity:AlertColor; | ||
switch(true){ | ||
casematchingProvisioners===0: | ||
title="Build pending provisioner deployment"; | ||
detail= | ||
"Your build has been enqueued, but there are no provisioners that accept the required tags. Once a compatible provisioner becomes available, your build will continue. Please contact your administrator."; | ||
severity="warning"; | ||
break; | ||
caseavailableProvisioners===0: | ||
title="Build delayed"; | ||
detail= | ||
"Provisioners that accept the required tags have not responded for longer than expected. This may delay your build. Please contact your administrator if your build does not complete."; | ||
severity="warning"; | ||
break; | ||
default: | ||
title="Build enqueued"; | ||
detail= | ||
"Your build has been enqueued and will begin once a provisioner becomes available to process it."; | ||
severity="info"; | ||
} | ||
return( | ||
<ProvisionerAlert | ||
title={title} | ||
detail={detail} | ||
severity={severity} | ||
tags={tags} | ||
/> | ||
); | ||
}; |
36 changes: 36 additions & 0 deletionssite/src/pages/CreateTemplatePage/BuildLogsDrawer.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 15 additions & 1 deletionsite/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.