NotificationsYou must be signed in to change notification settings
Fork915
Star10.1k

chore: rework RPC version negotiation#15687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 5 commits intomainfromdean/rpc-version-rework

Dec 4, 2024

Merged

chore: rework RPC version negotiation#15687

deansheather merged 5 commits intomainfromdean/rpc-version-rework

Dec 4, 2024

Conversation

Copy link

Member

deansheather commentedNov 29, 2024

Changes the RPC header format fromcodervpn <version> <role> tocodervpn <role> <version1,version2,...>.

The versions list is a list of the maximum supported minor version for each major version, sorted by major versions.

E.g.1.0,2.3,3.1 means1.0, 2.0, 2.1, 2.2, 2.3, 3.0, 3.1 are supported.

When we eventually support multiple versions, the peer's version list will be compared against the current supported versions list to determine the maximum major and minor version supported by both peers.

Closes#15601

chore: rework RPC version negotiation

292c741

Changes the RPC header format from `codervpn <version> <role>` to`codervpn <role> <version1,version2,...>`.The versions list is a list of the maximum supported minor version foreach major version, sorted by major versions.E.g. `1.0,2.3,3.1` means `1.0, 2.0, 2.1, 2.2, 2.3, 3.0, 3.1` aresupported.When we eventually support multiple versions, the peer's version listwill be compared against the current supported versions list todetermine the maximum major and minor version supported by both peers.