Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add a provisioner warning to workspace builds#15686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 32 commits intomainfromjjs/workspace-provisioner-alert
Dec 11, 2024

Conversation

SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedNov 29, 2024•
edited
Loading

This PR adds warnings about provisioner health to workspace build pages.
Itcloses#15048

image
image

@SasSwartSasSwart changed the titleadd alert for workspace provisioningfeat(site): add a provisioner warning to workspace buildsDec 5, 2024
@SasSwartSasSwart requested review fromBrunoQuaresma andmtojek and removed request forjohnstcnDecember 5, 2024 09:10
@SasSwartSasSwart marked this pull request as ready for reviewDecember 5, 2024 09:11
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedDec 5, 2024•
edited
Loading

✔️ PR 15686 Updated successfully.
🚀 Access the credentialshere.

cc:@SasSwart

github-actions[bot] reacted with rocket emoji

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left 2 tiny nitpicks.

LGTM 👍

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ship it! Thanks for all changes.

@SasSwart
Copy link
ContributorAuthor

Thanks@mtojek. The frontend works, but in PR env testing I noticed the backend doesn't populate the fields where it needs to. One more commit just to fix that and then we'll ship. Apologies for the premature review.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@SasSwartSasSwart merged commitb39becb intomainDec 11, 2024
33 checks passed
@SasSwartSasSwart deleted the jjs/workspace-provisioner-alert branchDecember 11, 2024 11:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UX when there is no corresponding provisioner for a workspace/template
3 participants
@SasSwart@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp