Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(cli): handle version mismatch re MatchedProvisioners response#15682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 9 commits intomainfromcj/templateversion-matched-provisioners-ptr
Nov 29, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedNov 28, 2024•
edited
Loading

  • ModifiesMatchedProvisioners response ofcodersdk.TemplateVersion to be a pointer
  • CLI now checks for absence of*MatchedProvisioners before showing warning regarding provisioners
  • Extracts logic for warning about provisioners to a function
  • Improves test coverage for CLI template push withcoder_workspace_tags.

@johnstcnjohnstcn self-assigned thisNov 28, 2024
@johnstcnjohnstcnforce-pushed thecj/templateversion-matched-provisioners-ptr branch fromec9f677 toa266455CompareNovember 28, 2024 20:18
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Nothing blocking from my side

@johnstcnjohnstcn merged commit3014713 intomainNov 29, 2024
27 checks passed
@johnstcnjohnstcn deleted the cj/templateversion-matched-provisioners-ptr branchNovember 29, 2024 19:46
johnstcn added a commit that referenced this pull requestDec 12, 2024
…5682)* Modifies `MatchedProvisioners` response of `codersdk.TemplateVersion`to be a pointer* CLI now checks for absence of `*MatchedProvisioners` before showingwarning regarding provisioners* Extracts logic for warning about provisioners to a function* Improves test coverage for CLI template push with`coder_workspace_tags`.(cherry picked from commit3014713)
johnstcn added a commit that referenced this pull requestDec 12, 2024
…5682)* Modifies `MatchedProvisioners` response of `codersdk.TemplateVersion`to be a pointer* CLI now checks for absence of `*MatchedProvisioners` before showingwarning regarding provisioners* Extracts logic for warning about provisioners to a function* Improves test coverage for CLI template push with`coder_workspace_tags`.(cherry picked from commit3014713)
johnstcn added a commit that referenced this pull requestDec 12, 2024
…5682)* Modifies `MatchedProvisioners` response of `codersdk.TemplateVersion`to be a pointer* CLI now checks for absence of `*MatchedProvisioners` before showingwarning regarding provisioners* Extracts logic for warning about provisioners to a function* Improves test coverage for CLI template push with`coder_workspace_tags`.(cherry picked from commit3014713)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@SasSwartSasSwartSasSwart approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@dannykopping@SasSwart
[8]ページ先頭
©2009-2025 Movatter.jp