Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: use url-parse for url construction#15670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 18 commits intomainfromjon/codeql
Nov 27, 2024
Merged

fix: use url-parse for url construction#15670

sreya merged 18 commits intomainfromjon/codeql
Nov 27, 2024

Conversation

sreya
Copy link
Collaborator

This fixes some CodeQL-flagged issues. They're not real issues but the refactor is small and it'll keep the analysis tools quiet.

@sreyasreya requested a review fromaslilacNovember 27, 2024 12:15
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we should use the built-inURL type instead.

from the url-parse readme:

url-parse was created in 2014 when the WHATWG URL API was not available in Node.js and the URL interface was supported only in some browsers. Today this is no longer true. The URL interface is available in all supported Node.js release lines and basically all browsers. Consider using it for better security and accuracy.

sreya reacted with thumbs up emoji
@sreyasreya requested a review fromaslilacNovember 27, 2024 18:28
@sreyasreya requested a review fromaslilacNovember 27, 2024 18:55
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

couple small notes, but this looks great 👍

@sreyasreya merged commitffb0ebb intomainNov 27, 2024
26 of 28 checks passed
@sreyasreya deleted the jon/codeql branchNovember 27, 2024 21:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sreya@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp