Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add RBAC to /workspace endpoints#1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 10 commits intomainfromstevenmasley/rbac_org_endpoints
May 18, 2022

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedMay 18, 2022•
edited
Loading

Added routes:

"GET:/api/v2/workspaceresources/{workspaceresource}""GET:/api/v2/workspacebuilds/{workspacebuild}""GET:/api/v2/workspacebuilds/{workspacebuild}/logs":"GET:/api/v2/workspacebuilds/{workspacebuild}/resources":"GET:/api/v2/workspacebuilds/{workspacebuild}/state":"PATCH:/api/v2/workspacebuilds/{workspacebuild}/cancel":"GET:/api/v2/workspaces/{workspace}/builds/{workspacebuildname}""GET:/api/v2/users/oauth2/github/callback":"POST:/api/v2/users/{user}/organizations":"GET:/api/v2/workspaces/{workspace}""PUT:/api/v2/workspaces/{workspace}/autostart":"PUT:/api/v2/workspaces/{workspace}/autostop":"GET:/api/v2/workspaces/{workspace}/builds":"POST:/api/v2/workspaces/{workspace}/builds":

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable. Just to triple check, this still permits admins to view all workspaces, right?

@Emyrk
Copy link
MemberAuthor

Seems reasonable. Just to triple check, this still permits admins to view all workspaces, right?

Yup! I need to make another unit test that will provably assert this kind of thing. I will get to that next.

@EmyrkEmyrk merged commitc034e83 intomainMay 18, 2022
@EmyrkEmyrk deleted the stevenmasley/rbac_org_endpoints branchMay 18, 2022 23:15
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* feat: Add RBAC to /workspace endpoints
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp