Dec 5, 2024 · Nov 26, 2024 · Dec 3, 2024 · Dec 3, 2024
diff --git a/.golangci.yaml b/.golangci.yaml
      - name: modifies-value-receiver
      - name: package-comments
      - name: range
      - name: range-val-address
      - name: range-val-in-closure
      - name: receiver-naming
      - name: redefines-builtin-id
      - name: string-of-int
  govet:
    disable:
      - loopclosure
  gosec:
    excludes:
      # Implicit memory aliasing of items from a range statement (irrelevant as of Go v1.22)
      - G601

 issues:
  # Rules listed here: https://github.com/securego/gosec#available-rules
    - errname
    - errorlint
    - exhaustruct
    - exportloopref
    - forcetypeassert
    - gocritic
    # gocyclo is may be useful in the future when we start caring
diff --git a/vpn/client.go b/vpn/client.go
 "tailscale.com/net/dns"
 "tailscale.com/wgengine/router"

 "github.com/google/uuid"
 "github.com/tailscale/wireguard-go/tun"

 "cdr.dev/slog"

 type Conn interface {
 CurrentWorkspaceState() (tailnet.WorkspaceUpdate, error)
 GetPeerDiagnostics(peerID uuid.UUID) tailnet.PeerDiagnostics
 Close() error
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -175,8 +175,6 @@ linters-settings:
		- name: modifies-value-receiver
		- name: package-comments
		- name: range
		- name: range-val-address
		- name: range-val-in-closure
Copy link MemberAuthor ethanndicksonDec 3, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Outdated:https://github.com/mgechev/revive/blob/v1.5.1/RULES_DESCRIPTIONS.md#range-val-address spikecurtis reacted with thumbs up emoji
		- name: receiver-naming
		- name: redefines-builtin-id
		- name: string-of-int
Expand All		@@ -199,6 +197,10 @@ linters-settings:
		govet:
		disable:
		- loopclosure
		gosec:
		excludes:
		# Implicit memory aliasing of items from a range statement (irrelevant as of Go v1.22)
		- G601

		issues:
		# Rules listed here: https://github.com/securego/gosec#available-rules
Expand DownExpand Up		@@ -238,7 +240,6 @@ linters:
		- errname
		- errorlint
		- exhaustruct
		- exportloopref
Copy link MemberAuthor ethanndicksonDec 3, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Outdated:https://github.com/kyoh86/exportloopref
		- forcetypeassert
		- gocritic
		# gocyclo is may be useful in the future when we start caring
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -11,6 +11,7 @@ import (
		"tailscale.com/net/dns"
		"tailscale.com/wgengine/router"

		"github.com/google/uuid"
		"github.com/tailscale/wireguard-go/tun"

		"cdr.dev/slog"
Expand All		@@ -23,6 +24,7 @@ import (

		type Conn interface {
		CurrentWorkspaceState() (tailnet.WorkspaceUpdate, error)
		GetPeerDiagnostics(peerID uuid.UUID) tailnet.PeerDiagnostics
		Close() error
		}

Expand Down