Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd): extract provisionerdserver.StaleInterval to 90 seconds#15643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/provisionerdserver-staleheartbeats
Nov 28, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedNov 25, 2024•
edited
Loading

Follow-up from#15578

Extractsprovisionerdserver.StaleInterval and sets it to 90 seconds by default

@johnstcnjohnstcn self-assigned thisNov 25, 2024
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is an improvement, but I still find this approach lacking.

@johnstcnjohnstcn changed the titlefix(coderd): extract provisionerdserver.StaleHeartbeats, reduce from 3 to 2fix(coderd): extract provisionerdserver.StaleInterval to 90 secondsNov 25, 2024
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for making the change 👍🏻, if we noticed that the decreased interval leads to too many false-positive stale states, then we can consider raising it to 150s or something like that.


// StaleInterval is the amount of time after the last heartbeat for which
// the provisioner will be reported as 'stale'.
StaleInterval = 90 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If I configure my heartbeat interval to be greater than 90 sec, it reads like this will introduce false negatives where a heartbeat simply hasn't run but the provisioner presents as stale. Am I missing something?

Copy link
MemberAuthor

@johnstcnjohnstcnNov 28, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep, but we don't expose that as acoderd configuration knob yet. The only way you could configure that is by editing the source code right now.

@johnstcnjohnstcn merged commitef09b51 intomainNov 28, 2024
33 checks passed
@johnstcnjohnstcn deleted the cj/provisionerdserver-staleheartbeats branchNovember 28, 2024 12:57
johnstcn added a commit that referenced this pull requestDec 12, 2024
…15643)Follow-up from#15578Extracts `provisionerdserver.StaleInterval` and sets it to 90 seconds bydefault(cherry picked from commitef09b51)
johnstcn added a commit that referenced this pull requestDec 12, 2024
…15643)Follow-up from#15578Extracts `provisionerdserver.StaleInterval` and sets it to 90 seconds bydefault(cherry picked from commitef09b51)
johnstcn added a commit that referenced this pull requestDec 12, 2024
…15643)Follow-up from#15578Extracts `provisionerdserver.StaleInterval` and sets it to 90 seconds bydefault(cherry picked from commitef09b51)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SasSwartSasSwartSasSwart left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@mafredri@SasSwart
[8]ページ先頭
©2009-2025 Movatter.jp