- Notifications
You must be signed in to change notification settings - Fork906
chore: add csharp_namespace to vpn.proto#15634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vpn/vpn.proto Outdated
| @@ -1,5 +1,6 @@ | |||
| syntax = "proto3"; | |||
| option go_package = "github.com/coder/coder/v2/vpn"; | |||
| option csharp_namespace = "Coder.Desktop.Rpc.Proto"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Coder Desktop is the entire desktop application, and Coder VPN is the feature. So, I think we should qualify the namespace to "VPN" somehow, since this protocol really is specific to Coder VPN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The whole solution is namedCoder.Desktop. I could rename the solution toCoder.Vpn but it would make less sense because then the UI project would be namedCoder.Vpn.Desktop (or something). We want to keep all the code in a single solution so we don't need to mess with packaging the library packages for consumption in a different solution.
There's also no VPN-specific components in the C# code unlike with the Mac version, just a service manager and UI, which makes me inclined to keep it named asCoder.Desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can move it toCoder.Desktop.Vpn.Rpc orCoder.Desktop.VpnRpc perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the whole solution should still beCoder.Desktop, and this could beCoder.Desktop.Vpn.Rpc (or even justCoder.Desktop.Vpn if you don't think we need the "RPC" qualifier). Not sure what feels more natural in C#.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah we could doCoder.Desktop.Vpn. I might rename some of my types to e.g.RpcSpeaker though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The protocol will still beCoder.Desktop.Vpn.Proto since it's in it's own project
06c9979 intomainUh oh!
There was an error while loading.Please reload this page.
coder/coder-desktop-windows#6