- Notifications
You must be signed in to change notification settings - Fork1k
chore: fix more flaky tests on Windows with Postgres#15629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coderd/database/dbgen/dbgen.go Outdated
| }) | ||
| require.NoError(t,err,"insert workspace agent script") | ||
| returntiming | ||
| fori:=0;i<2500;i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm guessing you didn't mean to add leave this loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
2500 retries was a little excessive, lowered it to 10
| WaitShort=30*time.Second | ||
| WaitMedium=40*time.Second | ||
| WaitLong=70*time.Second | ||
| WaitSuperLong=240*time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💀
83c493e intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Addresses the following flakes:
I temporarily enabled CI with Windows/PG in a previous commit and re-run it 3 times. It passed 3 times in a row:https://github.com/coder/coder/actions/runs/12012729874/job/33489594597